Dns query response time #694
Conversation
| @@ -4,3 +4,5 @@ tivan | |||
| .idea | |||
| *~ | |||
| *# | |||
|
|
|||
| *.iml | |||
There was a problem hiding this comment.
please don't add this to the gitignore, these type of things should go in your global gitignore
There was a problem hiding this comment.
I saw .idea entry ;-)
But ok. I have removed this commit :-)
| dnsQueryTime := float64(0) | ||
|
|
||
| c := new(dns.Client) | ||
| c.ReadTimeout = time.Duration(d.Timeout) * time.Second |
There was a problem hiding this comment.
this should be just d.Timeout * time.Second
|
This looks great, a couple comments:
|
| "recordType": d.RecordType, | ||
| } | ||
|
|
||
| acc.Add("dns", dnsQueryTime, tags) |
There was a problem hiding this comment.
change this to AddFields, and add something like:
fields = map[string]string{"query_time_ms": dnsQueryTime}There was a problem hiding this comment.
this is just in case we would like to add more metrics to this plugin in the future
I can rebase the branch up to master before merge if you wish |
| @@ -157,6 +157,8 @@ Currently implemented sources: | |||
| * bcache | |||
| * couchdb | |||
| * disque | |||
| * dns | |||
There was a problem hiding this comment.
yes, also the package (and directory) name
|
great, I'll get this merged once CI passes, thanks @mjasion |
|
Yeah, im working on it :P i will ping you |
mjasion
force-pushed
the
dns_query
branch
2 times, most recently
from
64779d3 to
35b8313
Compare
small polishings added more record types - AAAA and ANY
- domains are optional - new record types
|
@sparrc CI passed :-) |
- renamed plugin to dns_query - domains are optional - new record types closes influxdata#694
Input plugin for measure dns response time