Rewrite documentation for snmp input #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
docs
reimda
reviewed
Dec 13, 2019
plugins/inputs/snmp/README.md
Outdated
|
|
||
| ### Example: | ||
| These programs will load available MIBs on the system. Typically the default | ||
| directory for MIBs is `/usr/share/snmp/mibs`, but if you MIBs are in a |
reimda
reviewed
Dec 16, 2019
|
|
||
| ### MIB lookups |
There was a problem hiding this comment.
The snmp trap input's readme refers to this section by name. Since the section is removed in this change we'll need to update snmp_trap/README.md. It looks like the content is moved to the prerequisites section.
reimda
suggested changes
Dec 16, 2019
|
I decided to copy/paste the prerequisites section over the snmp_trap docs, if you feel strongly against this duplication I'll undo. In the snmp_trap version I only mention needing I made some minor changes in snmp_trap docs, moving the port into a sub section under the Configuration section and removed the description from the sample configuration. One thing I was wondering is if we need to remove the mention of INFORM from the snmp_trap docs, these won't work yet will they? |
reimda
approved these changes
Dec 17, 2019
danielnelson
added a commit
that referenced
this pull request
Dec 30, 2019
(cherry picked from commit c325c94)
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6736
Required for all PRs: