Override github.com/satori/go.uuid revision for transitive deps #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there has been a workaround in place for some time, this change is being made to reduce confusion around if Telegraf is affected by satori/go.uuid#73
danielnelson
added a commit
that referenced
this pull request
Dec 7, 2019
While there has been a workaround in place for some time, this change is being made to reduce confusion around if Telegraf is affected by satori/go.uuid#73 (cherry picked from commit f0b0295)
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
…uxdata#6768) While there has been a workaround in place for some time, this change is being made to reduce confusion around if Telegraf is affected by satori/go.uuid#73
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
…uxdata#6768) While there has been a workaround in place for some time, this change is being made to reduce confusion around if Telegraf is affected by satori/go.uuid#73
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
…uxdata#6768) While there has been a workaround in place for some time, this change is being made to reduce confusion around if Telegraf is affected by satori/go.uuid#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is being made to reduce confusion around if Telegraf is affected by satori/go.uuid#73. Neither Telegraf 1.12 or 1.13 are affected by this issue, I have not investigated earlier versions.
Telegraf dropped this library as a direct dependency in 1.13, moving to gofrs. In Telegraf 1.12, we do use the affected library, but only for random partitioning in the kinesis and kafka outputs where randomness is not a security issue.
This library still exists as a transitive dependency for the Microsoft Application Insights output plugin. However, they have worked around this bug in their library and we have had the fix since Telegraf 1.8: https://github.com/microsoft/ApplicationInsights-Go/blob/master/appinsights/uuid.go#L14-L21
At first glance it may also appear that the pgx package uses this library, but we are not using the portion of code that includes it.
Required for all PRs: