-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.win_perf_counters): Add remote computers support #6590
feat(inputs.win_perf_counters): Add remote computers support #6590
Conversation
Is there any ETA that PR will be merged? |
@vlastahajek are you interested in continuing this? Looks like a rebase on master to resolve some conflicts, and then a few outstanding points are what is left. |
@powersj, OK. I will look at this later this week or at the beginning of the next week. |
442598d
to
4f6b5bf
Compare
4f6b5bf
to
850677d
Compare
It's ready. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
I moved these changes to a local branch and created a new pull request: #11090. At the moment we are waiting for customer/community participation to help ensure this change meets their needs (configuration makes sense, etc.). Therefore we will need to be able to re-base it and get new build artifacts on request, moving this pull request to be under a local branch seems like the best approach. Thank you @vlastahajek for all your work on this and quick responses, I will be closing this pull request so you aren't responsible anymore for helping us re-base it while we wait. |
Resolves #1899
Added support for reading performance counters from remote computers. User, under who is Telegraf running, must be already authenticated to the remote computer(s).
The support is added via additional optional global parameter
Sources
. This parameter can be also set for performance object to configure per host-specific performance counter:It allows to define the same configuration for multiple computers and also different configurations per computer.
Computer name is then added as the
source
tag. Telegraf host compuper has thesource
set to the computer name.Readme has been also enhanced with plugins's schema description.
Required for all PRs: