Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pulling metrics from a dropwizard application #3531

Conversation

grange74
Copy link
Contributor

@grange74 grange74 commented Dec 1, 2017

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

We have an open pull request for adding dropwizard as a parser, I think this is the best solution for dropwizard because it decouples the data format from the transport. I encourage you to take a look at the pull request and comment on if it will work or any ideas you have:

#2846

I think the other half of this that we need is a http input plugin, similar to httpjson, but allowing any parser to be used:

#813
#1758 (comment)

@grange74
Copy link
Contributor Author

grange74 commented Dec 1, 2017

Ok, separating the data format from the transport makes a lot of sense.

I guess in the long term a lot of the input plugins could be converted into parsers as many of the ones I looked at to model off this off just pulled json (or xml) from a HTTP endpoint (e.g. influxdb, kapacitor, tomcat).
Having a simple http input plugin that supports custom parsers and various forms of authentication would be nice.
Please let me know if there is anything that I can help with.

One feature that was implemented in this PR, was to skip Idle metrics. That doesn't sound like something that should go into a parser. Would you see this as a generic feature and if so where would it fit in?

@danielnelson
Copy link
Contributor

For idle metrics, the best idea I have seen is the idea in #3388.

@danielnelson
Copy link
Contributor

I'm not aware of anyone working on the generic http input plugin, it would probably be fairly similar to this pull request without the dropwizard code but using the Parser interface. Would you be interested in helping with this?

@grange74
Copy link
Contributor Author

grange74 commented Dec 4, 2017

Sure, i'd be happy to help with the "generic http input plugin". I had a quick look at some of the existing input plugins that implement the Parser interface (e.g. nsq_consumer) and they seem very straight forward.

Given that there are already several http input plugins (i.e. http_listener, http_response, httpjson), what would you want this one called? just http or something else?

We can probably close this PR now and create a new issue to describe the new "generic http input plugin" to document the desired behaviour.

@danielnelson
Copy link
Contributor

We can use #813 for tracking the issue. I think we should just name it http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants