Test #3316
Closed
Test #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmyers808
force-pushed
the
rmyers_avs_engine_stats
branch
from
15a3a30 to
0f452ad
Compare
adamchainz
added a commit
to adamchainz/telegraf
that referenced
this pull request
Oct 12, 2017
Fixes influxdata#3316. Use STS to validate the provided credentials work, rather than `ListMetricData` which requires a separate permission, and document the required permission. - [x] Signed [CLA](https://influxdata.com/community/cla/). - [x] Associated README.md updated. - [x] Has appropriate unit tests. I'm not sure about unit tests since none exist using mock AWS, but I did some manual testing. I made a test IAM user with only `cloudwatch:PutMetricData` permission, policy: ``` { "Version": "2012-10-17", "Statement": [ { "Effect": "Allow", "Action": [ "cloudwatch:PutMetricData" ], "Resource": [ "*" ] } ] } ``` I then used its access key as environment variables locally and ran telegraf in this environment, with this config: ```ini [agent] debug = "true" [[outputs.cloudwatch]] region = "eu-west-1" namespace = "InfluxData/Telegraf" [[inputs.cpu]] ``` I then successfully saw data flushed when running telegraf like so: ``` $ ./telegraf --config test.conf 2017-10-12T22:23:07Z D! Attempting connection to output: cloudwatch 2017-10-12T22:23:07Z D! Successfully connected to output: cloudwatch 2017-10-12T22:23:07Z I! Starting Telegraf v1.5.0~c74c29b1 2017-10-12T22:23:07Z I! Loaded outputs: cloudwatch 2017-10-12T22:23:07Z I! Loaded inputs: inputs.cpu 2017-10-12T22:23:07Z I! Tags enabled: host=Adams-MacBook-Pro-2.local 2017-10-12T22:23:07Z I! Agent Config: Interval:10s, Quiet:false, Hostname:"Adams-MacBook-Pro-2.local", Flush Interval:10s 2017-10-12T22:23:20Z D! Output [cloudwatch] buffer fullness: 9 / 10000 metrics. 2017-10-12T22:23:21Z D! Output [cloudwatch] wrote batch of 9 metrics in 976.776485ms ^C2017-10-12T22:23:26Z I! Hang on, flushing any cached metrics before shutdown 2017-10-12T22:23:26Z D! Output [cloudwatch] buffer fullness: 0 / 10000 metrics. ``` And I also checked with bad credentials and saw the error message: ``` $ AWS_ACCESS_KEY_ID=foobar ./telegraf --config test.conf 2017-10-12T22:24:50Z E! cloudwatch: Cannot use credentials to connect to AWS : InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 2824d227-af9c-11e7-aa9b-f5e6ab3e0c4c 2017-10-12T22:24:50Z E! Failed to connect to output cloudwatch, retrying in 15s, error was 'InvalidClientTokenId: The security token included in the request is invalid. status code: 403, request id: 2824d227-af9c-11e7-aa9b-f5e6ab3e0c4c' ```
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: