Use chunked transfer encoding in InfluxDB output #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current streaming implementation we cannot correctly determine the size of the output unless we were to buffer the output fully, because the actual size depending on if any splitting is performed.
danielnelson
added a commit
that referenced
this pull request
Oct 5, 2017
(cherry picked from commit cce40c5)
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the Content-Length header from all POSTs to InfluxDB.
With the current metrics.Reader the content length cannot be determined without buffering the full request body. Our choice to fix this issue then are:
The later was the quickest and least risk, so I went with that for now. In the future, I think we should replace the metrics.Reader with a more appropriate abstraction, as it doesn't allow for the line based structure of line protocol very well.
closes #2854
Required for all PRs:
Associated README.md updated.N/A