Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.proxmox): Allow search domain to be empty #16511

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 13, 2025

Summary

Currently, Telegraf errors out if no search domain is configured for the proxmox node. However, the search domain is only used for outputting the FQDN for the node (and VM). This PR prevents Telegraf from erroring out at the cost of not getting the FQDN of the node.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16475

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 13, 2025
@srebhan srebhan self-assigned this Feb 13, 2025
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 17, 2025
@srebhan srebhan assigned DStrand1 and unassigned srebhan Feb 17, 2025
@DStrand1 DStrand1 merged commit 5e51e4e into influxdata:master Feb 18, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.3 milestone Feb 18, 2025
srebhan added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E! [inputs.proxmox] Error in plugin: search domain is not set
2 participants