Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.nsdp): Add plugin #16392

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(inputs.nsdp): Add plugin #16392

wants to merge 7 commits into from

Conversation

hdecarne
Copy link
Contributor

Summary

This PR provides the inputs.nsdp plugin for collecting statistics from from NSDP
(Netgear Switch Discovery Protocol) capable devices.

I previously contributed this plugin as an external one. As part of the latest reworks I also converted it into an internal one.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16391

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 11, 2025
srebhan
srebhan reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hdecarne for your contribution. I do have some comments in the code. For your other PR of the same structure, please also apply the comments there (if applicable) to save some review rounds!

@srebhan srebhan self-assigned this Feb 14, 2025
@srebhan srebhan changed the title feat(inputs.nsdp): Make inputs.nsdp an internal plugin feat(inputs.nsdp): Add plugin Feb 14, 2025
@hdecarne
Copy link
Contributor Author

@srebhan, I have incorporated your comments and also re-worked overall to match the comments from the other PR.

srebhan
srebhan reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework @hdecarne! Some smaller comments in the code...

srebhan
srebhan reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdecarne almost. :-) Two more minor comments in the code and the request to error out on invalid timeouts rather than overriding them.

@hdecarne
Copy link
Contributor Author

@srebhan, updated as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan left review comments

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert external plugin inputs.nsdp into an internal one
2 participants
@hdecarne @srebhan