chore: Remove revive:unhandled-error - errcheck is more flexible

[zak-pawel]

It doesn't make sense to support two linters for checking if returned error is handled.

errcheck is able to find more problems, and have default exclusion list (which can be extended in .golangci.yml)
https://github.com/kisielk/errcheck/blob/master/errcheck/excludes.go#L11

		// bytes
		"(*bytes.Buffer).Write",
		"(*bytes.Buffer).WriteByte",
		"(*bytes.Buffer).WriteRune",
		"(*bytes.Buffer).WriteString",

		// fmt
		"fmt.Errorf",
		"fmt.Print",
		"fmt.Printf",
		"fmt.Println",
		"fmt.Fprint(*bytes.Buffer)",
		"fmt.Fprintf(*bytes.Buffer)",
		"fmt.Fprintln(*bytes.Buffer)",
		"fmt.Fprint(*strings.Builder)",
		"fmt.Fprintf(*strings.Builder)",
		"fmt.Fprintln(*strings.Builder)",
		"fmt.Fprint(os.Stderr)",
		"fmt.Fprintf(os.Stderr)",
		"fmt.Fprintln(os.Stderr)",

		// io
		"(*io.PipeReader).CloseWithError",
		"(*io.PipeWriter).CloseWithError",

		// math/rand
		"math/rand.Read",
		"(*math/rand.Rand).Read",

		// strings
		"(*strings.Builder).Write",
		"(*strings.Builder).WriteByte",
		"(*strings.Builder).WriteRune",
		"(*strings.Builder).WriteString",

		// hash
		"(hash.Hash).Write",

revive allows to exclude only functions. errcheck supports also methods, so doesn't need a lot of repeating //nolint's in code.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[Hipska]

Maybe add a "closes #12892"?

[zak-pawel]

Maybe add a "closes #12892"?

Only when we agree to not enable gosec:G104 in #12892 ;)

[srebhan]

I think we do agree to not enable G104 for the reason you outlined, don't we @powersj?

[srebhan]

Looks good to me. Thanks for cleaning up @zak-pawel.
Additionally to these we might also want to cleanup all _, _ = xyz.Write... calls as they are also a product of these checks. You can find them with grep -nr '_, _ = (\w\+\.)\+Write' * ...

[zak-pawel]

Additionally to these we might also want to cleanup all _, _ = xyz.Write... calls as they are also a product of these checks. You can find them with grep -nr '_, _ = (\w\+\.)\+Write' * ...

Created new issue for that: #13013