-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Linter fixes for plugins/inputs/m* #10006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel! Only two minor comments/suggestions. Feel free to ignore them if you don't like them. :-)
🥳 This pull request decreases the Telegraf binary size by -0.01 % for linux amd64 (new size: 132.1 MB, nightly size 132.1 MB) 📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @zak-pawel for silencing another bunch of those...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! There are a couple of logic-like changes where you moved functions around, but I think it all still looks good. Thanks again!
(cherry picked from commit c1d4ce4)
Following findings were fixed: