Add a generic HTTPPost node #1331
Conversation
|
@sputnik13 On first read through this look great! 👍 Questions:
I ask because both of these have been requested and are being added in #1254, for the alert post handler. @desa Seems like we can use your work in #1254 to add the same features to this new |
|
@nathanielc yeah I think that makes sense. Thoughts on the best way to do that? Should we get this merged and then I'll rebase and make the changes? |
|
@desa Yeah, I think it makes sense to merge this one first. Thanks |
| // .every(5s) | ||
| // |top('value', 10) | ||
| // //Post the top 10 results over the last 10s updated every 5s. | ||
| // |httpPost('http://example.com/api/top10') |
There was a problem hiding this comment.
@desa Does this TICKscript usage work well for how your post service is going to work? Is there a change that would make is easier more consistent with your changes?
There was a problem hiding this comment.
having an optional property method called endpoint would be useful, but I can add that once this is merged.
There was a problem hiding this comment.
@sputnik13 Thanks for the excellent PR! I am ready to merge this once @desa also approves that it will integrate well with his work.
|
@nathanielc sounds good, except during further internal testing we saw kapacitor hard crash when the POST endpoint wasn't available... not sure that's the best behavior, so I need to look in to this a bit more |
An HTTPPost node to mimic the behavior of HTTPOut, with the difference that data is POST'd to an HTTP endpoint rather than made available at a kapacitor endpoint. Closes influxdata#1330
|
@nathanielc it seems like closing resp.Body when http.Post fails causes a hard crash (doh)... fixed |
when http.Post fails, resp.Body.Close seems to cause a hard crash on the entire process
|
@sputnik13 is this PR ready to go? If so, could you squash and rebase onto master? |
|
@desa I'm sorry, I was busy with work, hadn't had a chance to check back, thanks for merging it |
|
@sputnik13 no worries 👍 . Thanks for the PR. |
An HTTPPost node to mimic the behavior of HTTPOut, with the difference
that data is POST'd to an HTTP endpoint rather than made available at a
kapacitor endpoint.
Closes #1330
Tested to ensure data is POST'd properly to a logstash instance, from which
metric data was pushed through our metric pipeline to a time series database.
Integration tests for stream and batch modes added and verified.
Required for all non-trivial PRs
Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.