Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if replay file has an extension #1228

Merged
merged 2 commits into from
Feb 27, 2017
Merged

check if replay file has an extension #1228

merged 2 commits into from
Feb 27, 2017

Conversation

sj14
Copy link
Contributor

@sj14 sj14 commented Feb 27, 2017

Adding a check, if the filenames inside the replay folder contain an extension, otherwise, Kapacitor will panic on startup.

Seems to be a trivial PR.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)
Required only if applicable

You can erase any checkboxes below this note if they are not applicable to your Pull Request.

@nathanielc
Copy link
Contributor

@sj14 Thanks! Can you add a bugfix changelog entry?

@sj14
Copy link
Contributor Author

sj14 commented Feb 27, 2017

@nathanielc Yes, see new commit.

Copy link
Contributor

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you sign the CLA? Once signed I'll merge. If signing is an issue let me know and I can close this out and make the change myself. Thanks for the PR!

@sj14
Copy link
Contributor Author

sj14 commented Feb 27, 2017

@nathanielc Yes, I have signed the CLA. Thanks for merging!

@nathanielc nathanielc merged commit 8e3c429 into influxdata:master Feb 27, 2017
nathanielc added a commit that referenced this pull request Feb 27, 2017
check if replay file has an extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants