Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in test helpers #8178

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Fix race in test helpers #8178

merged 1 commit into from
Mar 29, 2017

Conversation

e-dard
Copy link
Contributor

@e-dard e-dard commented Mar 21, 2017 •
edited by jwilder
Loading

LocalServer was racy with closing and writing.

Fixes #8177
Fixes #8159

@e-dard e-dard changed the title Fix race in test helpers, Fix race in test helpers Mar 21, 2017
@e-dard e-dard requested a review from jwilder March 21, 2017 12:08
@e-dard e-dard merged commit 374b04a into master Mar 29, 2017
@e-dard e-dard deleted the er-test-race branch March 29, 2017 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder jwilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-dard @jwilder