Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-check field type under write lock. #8092

Merged

Conversation

benbjohnson
Copy link
Contributor

@benbjohnson benbjohnson commented Mar 3, 2017

TODO

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

Fixes #8085

@benbjohnson benbjohnson requested a review from jwilder March 3, 2017 16:34
@benbjohnson benbjohnson force-pushed the field-type-conflict-write-check branch from f892e7f to 3d22da1 Compare March 3, 2017 16:35
CHANGELOG.md Outdated
@@ -19,6 +19,8 @@
- [#8044](https://github.com/influxdata/influxdb/issues/8044): Treat non-reserved measurement names with underscores as normal measurements.
- [#8078](https://github.com/influxdata/influxdb/issues/8078): Map types correctly when selecting a field with multiple measurements where one of the measurements is empty.
- [#8080](https://github.com/influxdata/influxdb/issues/8080): Point.UnmarshalBinary() bounds check
- [#8092](https://github.com/influxdata/influxdb/pull/8092): Re-check field type under write lock.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list the issue here instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4c202ee.

@benbjohnson benbjohnson force-pushed the field-type-conflict-write-check branch from 3d22da1 to 4c202ee Compare March 3, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants