Enterprise registration as a service #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
enterprise_stats
branch
2 times, most recently
from
badf06d to
6e0e33c
Compare
Registration also involves statistics and diagnostics upload, for the purposes of remote management. This means there will be long-running goroutines in effect. Therefore move the code to a service model.
otoolep
force-pushed
the
enterprise_stats
branch
from
6e0e33c to
667ad33
Compare
otoolep
force-pushed
the
enterprise_stats
branch
from
7c22a27 to
83db5cd
Compare
otoolep
force-pushed
the
enterprise_stats
branch
from
ad28554 to
f0c4501
Compare
|
How the diagnostics look: |
|
Looks good to me. |
|
I added the JSON tags to the Statistics struct. |
|
Good enough -- thanks @markbates -- I will merge on green. |
otoolep
added a commit
that referenced
this pull request
Oct 20, 2015
Enterprise registration as a service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registration also involves statistics and diagnostics upload, for the purposes of remote management. This means there will be long-running goroutines in effect. Therefore move the code to a new service, called
registration.This change also adds support for periodic stats upload to Enterprise. It does this by first exporting a previously unexported type in the
monitorservice, allowing the stats gathered by themonitorservice to be retrieved by other sub-systems. Then the newregistrationservice POSTs these stats periodically to Enterprise.