Retry monitor storage creation and only on Leader #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is idempotent and is storage has been successfully created, no attempt will be made to re-create it. This allows the system to keep trying every cycle, but stop when successful.
Since only the leader can create it, the system might as well only attempt creation on the leader.
otoolep
force-pushed
the
retry_mon_create
branch
from
d20727d to
a8e8ad2
Compare
|
+1 |
otoolep
force-pushed
the
retry_mon_create
branch
from
a8e8ad2 to
dba286a
Compare
otoolep
added a commit
that referenced
this pull request
Oct 5, 2015
Retry monitor storage creation and only on Leader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the monitor sub-system will retry creation of its internal storage. Previously any failure would cause internal storage to cease, meaning any temporary problems on the cluster would cause storage to cease until a node restart. Instead try every monitor cycle until creation is successful.
Furthermore, this creation only needs to be executed by one node, so only attempt it on the Leader.