Bugfix for #3429 String representations of RegexLiterals generated in… #3484
Conversation
| }, | ||
| &Query{ | ||
| name: "single field (regex tag match with escaping)", | ||
| command: `SELECT value FROM db0.rp0.status_code WHERE url !~ /http\:\/\/www\.akamai\.com/`, |
There was a problem hiding this comment.
Shouldn't the URL be influxdb.com in this test to match with line 887?
There was a problem hiding this comment.
There is an entry for both URLs with different values and then a test for match/no match. Might be a bit redundant.
Probably worth making the test URL influxdb.com regardless
|
@dawbs can you rebase to latest? |
dawbs
force-pushed
the
dawbs-fix-3429
branch
2 times, most recently
from
1f3c657 to
67760c7
Compare
|
@beckettsean rebased and URLs updated as discussed as well |
|
+1 |
…nerated in influxql/ast.go add the / char as a start and end delimiter, but does not escape any / characters that may exist with the regex
|
@beckettsean Have rebased this and fixed up the formatting changes to make circleci happy again - would be good to merge this in so I can push us back onto an upstream release :) |
|
@otoolep @corylanou @DanielMorsing can one of you guys review? |
|
This looks alright to me, but I'm wondering if there are other special characters that need to be escaped. |
|
@DanielMorsing not that I know of. We can fix those in a later PR if we run across them though so I'm going to go ahead and merge this. |
Bugfix for #3429 String representations of RegexLiterals generated in…
|
@dawbs thanks for following up and seeing it through! |
Fix for bug #3429
corrected issue where string representations of RegexLiterals generated in influxql/ast.go added the / char as a start/end delimiter, but did not escape any / characters that may exist with the regex.