refactor: writer-id to node-id
#25905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterbarnett03 if you don't mind, please take a look at the changes to the install script: https://github.com/influxdata/influxdb/pull/25905/files#diff-7765dbdf90d7078980bfd34e7a466cc932f0105fdebb9d9d9a85a3f3b6f866d2 |
pauldix
approved these changes
Jan 23, 2025
peterbarnett03
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Looks good to me. Won't be able to test until the new version is deployed.
Script change will happen immediately (or relatively, Cloudflare does some small adjustments). Deploy takes 10-15 minutes. So there will be a small gap for a moment; given we're in alpha, not too terrible for us to worry about, but something to know for future script changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/influxdata/influxdb_pro/issues/429
This changes the naming of the identifier used to uniquely identify an InfluxDB 3 server from
writer-idtonode-id.Therefore, the argument that is passed on server start will now be
--node-id(not--writer-id, or previously--host-id).This PR makes changes of naming throughout the codebase so that struct fields, variable names, function arguments, etc. all follow the new naming convention.