feat(processing_engine): integration with virtual environments. #25895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonrnewhouse
force-pushed
the
processing_engine/dependencies
branch
2 times, most recently
from
c8da105 to
e0485a9
Compare
jacksonrnewhouse
force-pushed
the
processing_engine/dependencies
branch
from
e0485a9 to
499153a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a draft PR to track progress on handling dependencies. The current changes look for a ".venv" folder in the plugin dir, and if there is one attempt to initialize a virtualenv. It mostly worked out of the box, the only addition I needed to make for pyo3 was to add the virtualenv's site-package dir to
PYTHONPATH.Before this becomes a proper PR I want the plugin engine to be initialized with some dependency manager specified (starting with pip and uv, I think), and then there be endpoints to install a dependency. Also you should be able to just pass in the virtualenv location if you'd like.