docs: update CONTRIBUTING.md #25837
Merged
docs: update CONTRIBUTING.md #25837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiltontj
requested review from
pauldix,
mgattozzi,
jacksonrnewhouse and
praveen-influx
|
|
||
| ```shell | ||
| TEST_LOG= cargo nextest run -p influxdb3 --nocapture |
There was a problem hiding this comment.
is it worth calling TEST_LOG out in the section above that lays out the cargo command to run normal test as well?
praveen-influx
approved these changes
Jan 15, 2025
hiltontj
force-pushed
the
hiltontj/contributing
branch
2 times, most recently
from
70e1c87 to
735f1cc
Compare
hiltontj
force-pushed
the
hiltontj/contributing
branch
from
735f1cc to
3850269
Compare
|
Okay, I think I got it now, updated the tests with logging section to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue for this.
I noticed some things in our
CONTRIBUTING.mdthat could be updated, namely:docs/pages that are in IOx, but not this repo