Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2281: passthru escapes when parsing regex #2488

Merged
merged 1 commit into from
May 6, 2015
Merged

fix #2281: passthru escapes when parsing regex #2488

merged 1 commit into from
May 6, 2015

Conversation

dgnorton
Copy link
Contributor

@dgnorton dgnorton commented May 4, 2015

Make the InfluxQL parser check for '/' escape and pass all other
escapes through to the Go regexp parser unmodified.

@dgnorton
Copy link
Contributor Author

dgnorton commented May 4, 2015

@marcosnils regular expressions go through two parsers, InfluxQL and Go's regexp. Both parsers use \ for escapes. What this PR does is make the InfluxQL parser only recognize one escape during regex parsing (\/), which is the InfluxQL regular expression delimiter. InfluxQL passes all other escape sequences through to Go's regexp parser.

@marcosnils
Copy link
Contributor

@dgnorton thanks for clarifying 👍

@toddboom
Copy link
Contributor

toddboom commented May 4, 2015

+1

toddboom added a commit that referenced this pull request May 6, 2015
fix #2281: passthru escapes when parsing regex
@toddboom toddboom merged commit 10285b6 into master May 6, 2015
@toddboom toddboom deleted the fix-2281 branch May 6, 2015 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants