fix: return and respect cursor errors #24791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally spurred by #24536 |
stuartcarnie
previously approved these changes
Mar 26, 2024
There was a problem hiding this comment.
👍🏻 great to see coverage
Co-authored-by: Stuart Carnie <[email protected]>
Co-authored-by: Stuart Carnie <[email protected]>
Co-authored-by: Stuart Carnie <[email protected]>
Co-authored-by: Stuart Carnie <[email protected]>
stuartcarnie
approved these changes
Mar 26, 2024
davidby-influx
added a commit
that referenced
this pull request
Mar 26, 2024
ArrayCursors were ignoring errors, which led to panics when nil cursors were operated on. This fix passes errors back up the stack and uses them to enforce healthy cursor creation. Closes #24789 --------- Co-authored-by: Stuart Carnie <[email protected]> (cherry picked from commit fe6c64b) closes #24836
davidby-influx
added a commit
that referenced
this pull request
Mar 26, 2024
ArrayCursors were ignoring errors, which led to panics when nil cursors were operated on. This fix passes errors back up the stack and uses them to enforce healthy cursor creation. Closes #24789 --------- Co-authored-by: Stuart Carnie <[email protected]> (cherry picked from commit fe6c64b) closes #24836
davidby-influx
added a commit
that referenced
this pull request
Mar 27, 2024
ArrayCursors were ignoring errors, which led to panics when nil cursors were operated on. This fix passes errors back up the stack and uses them to enforce healthy cursor creation. Closes #24789 --------- Co-authored-by: Stuart Carnie <[email protected]> (cherry picked from commit fe6c64b) closes #24836 (cherry picked from commit 49d0bef) closes #24826
davidby-influx
added a commit
that referenced
this pull request
Mar 27, 2024
ArrayCursors were ignoring errors, which led to panics when nil cursors were operated on. This fix passes errors back up the stack and uses them to enforce healthy cursor creation. Closes #24789 --------- Co-authored-by: Stuart Carnie <[email protected]> (cherry picked from commit fe6c64b) closes #24836 (cherry picked from commit 49d0bef) closes #24826
davidby-influx
added a commit
that referenced
this pull request
Apr 5, 2024
ArrayCursors were ignoring errors, which led to panics when nil cursors were operated on. This fix passes errors back up the stack and uses them to enforce healthy cursor creation. Closes #24789 --------- Co-authored-by: Stuart Carnie <[email protected]> (cherry picked from commit fe6c64b) closes #24824
davidby-influx
added a commit
that referenced
this pull request
Apr 8, 2024
ArrayCursors were ignoring errors, which led to panics when nil cursors were operated on. This fix passes errors back up the stack and uses them to enforce healthy cursor creation. Closes #24789 Co-authored-by: Stuart Carnie <[email protected]> (cherry picked from commit fe6c64b) closes #24824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.
Closes #24789