Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update broken flux and perf tests (2.7) #24619

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

bnpfeife
Copy link
Contributor

No description provided.

bnpfeife and others added 2 commits January 31, 2024 14:25
* chore: download repository key to file

* fix: broken perf tests

Some perf tests had to be temporarily disabled. Work is
needed in the pref_tests repositories to make them work
again.
* fix(tsi1/partition/test): fix data race in test code

TestPartition_Compact_Write_Fail test was not locking the partition
before changing the value of MaxLogFileSize. This PR exports the mutex
of the partition to allow the test to access it and lock. Alternatives
require more changes such as a Setter method if we need to hide the
mutex.

* fixes #24042, for #24040

* chore: complete renaming of mutex in file and fix flux test

The flux test is another failing test because it was using a relative
time range.
@bnpfeife bnpfeife self-assigned this Jan 31, 2024
@davidby-influx davidby-influx self-requested a review January 31, 2024 20:40
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnpfeife bnpfeife merged commit 2a06260 into 2.7 Jan 31, 2024
25 checks passed
@bnpfeife bnpfeife deleted the BNP_fix-perftest_2.7 branch January 31, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants