Term changes must be persisted to disk. #2209
Conversation
|
Thanks @cannium -- good catch. Reviewed by @benbjohnson -- merging on green. I had to kick the build due to a known issue with Continuous Queries. |
| @@ -959,7 +959,7 @@ func (l *Log) candidateLoop(closing <-chan struct{}) State { | |||
|
|
|||
| // Increment term and request votes. | |||
| l.mu.Lock() | |||
| l.term++ | |||
| l.mustSetTerm(l.term+1) | |||
| l.votedFor = l.id | |||
| term := l.term | |||
There was a problem hiding this comment.
This is not actually quite right, since l.term is no longer being incremented.
There was a problem hiding this comment.
Actually, mustSetTerm takes care of setting l.term so we're actually OK.
|
Closed in favour of #2219 as I need to make more changes to the branch. |
|
@cannium -- can you also sign the CLA? You can find it here: |
|
Signed. Just curious, what's the difference between this patch and that of #2219 ? |
|
The CHANGELOG. I needed this change in quickly to meet a build requirement. Otherwise I would have waited around, or added your repo as a remote, cherry-picked etc etc. Unfortunately I didn't have the time this time. |
No description provided.