Wait for first applied index on Log.Join(). #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the join method returned immediately after connecting. Now the join method will wait until the snapshot and/or log entry is replicated as well before returning.
|
I understand what this does. What does it help? |
|
Just makes sure that when |
|
@otoolep Yes. Should help to avoid some races when spinning up nodes in the tests. 👍 |
|
Great change. |
toddboom
added a commit
that referenced
this pull request
Apr 9, 2015
Wait for first applied index on Log.Join().
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
Update range function example constant to include now() instead of now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously the join method returned immediately after connecting. Now the join method will wait until the snapshot and/or log entry is replicated as well before returning.