feat(templates): Remove templates #19300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
force-pushed
the
deniz-remove-templates
branch
from
ec9fd3b to
ccb2c94
Compare
ebb-tide
changed the title
ebb-tide
force-pushed
the
deniz-remove-templates
branch
2 times, most recently
from
274acaf to
75ad7ef
Compare
hoorayimhelping
approved these changes
Aug 14, 2020
| // } | ||
|
|
||
| async getCreateDashboardItem(item){ | ||
| async getCreateDashboardItem(item){ | ||
| return await this.driver.findElement(By.css(`[data-testid^=add-resource-dropdown--][id='${item}']`)); | ||
| } | ||
|
|
There was a problem hiding this comment.
what's up with the spacing in this file?
ebb-tide
force-pushed
the
deniz-remove-templates
branch
3 times, most recently
from
dae9342 to
6c988a8
Compare
hoorayimhelping
force-pushed
the
deniz-remove-templates
branch
from
6c988a8 to
5d0d041
Compare
…ce new templates page behind feature flag
hoorayimhelping
force-pushed
the
deniz-remove-templates
branch
from
5d0d041 to
1f0f91e
Compare
hoorayimhelping
force-pushed
the
deniz-remove-templates
branch
from
1f0f91e to
59746f0
Compare
hoorayimhelping
added a commit
that referenced
this pull request
Aug 26, 2020
This reverts commit 543bbd1.
hoorayimhelping
added a commit
that referenced
this pull request
Aug 26, 2020
hoorayimhelping
added a commit
that referenced
this pull request
Aug 26, 2020
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7609
Removed places in the UI where we enable imports and exports from 'old' templates.
Kept code for creating dashboards and variables from 'old' templates, because the UI still uses 'old' templates to create dashboards for telegraf configs and for demodata.
kept the
@influxdb/influxdb-templatesdependency because the UI still uses them to create dashboards for telegraf configs.