fix(influx): drop global flags and replace with locals #18713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
18706/influx_config_host_parse
branch
2 times, most recently
from
bce2de6 to
002e732
Compare
sanderson
approved these changes
Jun 24, 2020
jsteenb2
force-pushed
the
18706/influx_config_host_parse
branch
from
002e732 to
1f55ee1
Compare
many spots in the CLI that global flags show up cause confusion or just add overhead with no value. This cleans that up. Other commands may have token removed if it does not pertain. commands that do not have global flags: * influx * influx completion * influx config (all sub commands as well) * influx template * influx template validate * influx transpile * influx version * all root commands that have no actions, aka influx organization
jsteenb2
force-pushed
the
18706/influx_config_host_parse
branch
from
1f55ee1 to
9d0e2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many spots in the CLI that global flags show up cause confusion or just
add overhead with no value. This cleans that up. Other commands may
have token removed if it does not pertain.
commands that do not have global flags:
note: this PR makes me very happy 🙃