fix(kv): Install feature-flag for switching between normal and simplified options parsing #18662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettbuddin
force-pushed
the
bb/task-options-extraction
branch
2 times, most recently
from
2fa6243 to
0863f63
Compare
…fied options parsing.
brettbuddin
force-pushed
the
bb/task-options-extraction
branch
from
0863f63 to
23b1825
Compare
brettbuddin
requested review from
a team,
GeorgeMac and
aanthony1243
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs a feature-flag to switch between normal options parsing and a simplified variant. In this simplified version, we are doing a naive extraction of the content
option task = { ... }and passing that through the options extractor on its own. This allows for tasks that use functions liketableFindto be saved correctly.An obvious drawback of this approach is that functions cannot be used to create the RHS of the assignment. Since most people don't do this, we should be safe until the Flux team provides some APIs for us to consume that do this extraction in a static manner.