chore: convert index list to resource list #18361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
requested review from
a team,
drdelambre,
alexpaxton and
ebb-tide
and removed request for
a team
reparker837
force-pushed
the
rp_tokens_using_resource_cards
branch
from
efda2b6 to
c81c053
Compare
|
🎉 |
|
are there e2e tests around this code to ensure the sorting order interaction remains the same after this change? it's been a bit since i've been in here... |
reparker837
force-pushed
the
rp_tokens_using_resource_cards
branch
2 times, most recently
from
8d945fe to
77ff3d3
Compare
|
@drdelambre good call, we updated them & they're ready for review! |
drdelambre
approved these changes
Jun 4, 2020
hoorayimhelping
force-pushed
the
rp_tokens_using_resource_cards
branch
from
77ff3d3 to
390ddaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13549