Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(launcher): e2e test memory limits #17498

Merged
merged 1 commit into from
Apr 2, 2020
Merged

test(launcher): e2e test memory limits #17498

merged 1 commit into from
Apr 2, 2020

Conversation

affo
Copy link
Contributor

@affo affo commented Mar 31, 2020

Testing memory limits from the launcher perspective.

Testing if memory gets properly deallocated using metrics.

This PR also adds setting memory limits for OSS via command line

@affo affo requested a review from GeorgeMac March 31, 2020 08:54
@affo affo force-pushed the la/test-mem-manager branch 3 times, most recently from e1aed4e to 844c727 Compare March 31, 2020 11:28
@affo affo force-pushed the la/test-mem-manager branch 2 times, most recently from a8e1799 to 58708dd Compare April 1, 2020 08:59
@affo affo marked this pull request as ready for review April 1, 2020 08:59
@@ -93,7 +93,7 @@ var (
},
Content: "content5",
}
doc6 = influxdb.Document{
doc6 = influxdb.Document{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go fmt

Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool set of tests

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little concern

query/control/memory.go Outdated Show resolved Hide resolved
@affo affo force-pushed the la/test-mem-manager branch 2 times, most recently from 6c7f775 to e59a91a Compare April 1, 2020 10:22
@affo affo force-pushed the la/test-mem-manager branch from e59a91a to 0322e34 Compare April 1, 2020 12:50
@affo affo force-pushed the la/test-mem-manager branch from 0322e34 to 3f9d768 Compare April 2, 2020 09:05
@affo affo force-pushed the la/test-mem-manager branch from 3f9d768 to 13fc4f3 Compare April 2, 2020 09:20
@affo affo merged commit 3f3074e into master Apr 2, 2020
@affo affo deleted the la/test-mem-manager branch April 2, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants