fix(ui): resolved telegraf bucket dropdown bug and undefined token issue #17363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
force-pushed
the
fix/telegraf-buckets-bug
branch
from
f7337a6 to
45b2e34
Compare
121watts
approved these changes
Mar 19, 2020
| try { | ||
| const state = getState() | ||
| const org = getOrg(state) | ||
| const telegraf = get(state, `resources.telegrafs.byID.${configID}`, '') |
There was a problem hiding this comment.
already a selector for this getByID<Telegraf>(state, id)
| const org = getOrg(state) | ||
| const telegraf = get(state, `resources.telegrafs.byID.${configID}`, '') | ||
| const bucketName = get(telegraf, 'metadata.buckets[0]', '') | ||
| const bucket = getBucketByName(state, bucketName) |
There was a problem hiding this comment.
should handle no bucket name being on the telegraf config.
| import {isSystemBucket} from 'src/buckets/selectors' | ||
|
|
||
| // Utils | ||
| import {isSystemBucket} from 'src/buckets/constants/index' |
There was a problem hiding this comment.
Suggested change
| import {isSystemBucket} from 'src/buckets/constants/index' | |
| import {isSystemBucket} from 'src/buckets/constants' |
| state: AppState, | ||
| bucketName: string | ||
| ): Bucket => { | ||
| const buckets = state.resources.buckets.byID |
There was a problem hiding this comment.
there's already a selector for this also which will get all buckets and return them in a list for you 😄
| } | ||
|
|
||
| return auth.token | ||
| } |
| const config = { | ||
| ...tc, | ||
| labels: [label], | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17118
Problem
Solution
After speaking with @alexpaxton, it became clear that having a button underneath the code snippet made more sense to include rather than having a small button on the same line as the code