Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): make label service authorized by default #17285

Merged
merged 1 commit into from
Mar 16, 2020
Merged

fix(http): make label service authorized by default #17285

merged 1 commit into from
Mar 16, 2020

Conversation

affo
Copy link
Contributor

@affo affo commented Mar 16, 2020

This PR does 2 things:

  • makes it so that every resource uses an authorizer.LabelService by default.
  • fixes resource type for label backends: some of them where mounted on the right endpoint, but with the wrong resource type (bad copy paste?)

@affo
fix(http): make label service authorized by default
8a368fa 
Fix resource type for label backends.
@affo affo requested a review from gavincabbage March 16, 2020 10:35
@affo affo self-assigned this Mar 16, 2020
gavincabbage
gavincabbage approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@gavincabbage gavincabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch finding those bad copy pastes!

@affo affo merged commit 04b86df into master Mar 16, 2020
@affo affo deleted the la/fix-label-service branch March 16, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavincabbage gavincabbage gavincabbage approved these changes

Assignees

@affo affo

Labels
team/compute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@affo @gavincabbage