Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui/src/alerting): reduce points per check from 300 to 100 #17237

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

desa
Copy link
Contributor

@desa desa commented Mar 12, 2020

This was done to reduce amount of data returned to the client. This is
problematic when there are a large number of series that get returned
from a query. Long term we will want to limit the topN tables so that
this is not an issue.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@desa desa requested review from a team and zoesteinkamp and removed request for a team March 12, 2020 23:06
Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo 🍰 :shipit: lgtm

@hoorayimhelping
Copy link
Contributor

this is problematic when there are a large number of series that get returned
from a query

does this affect smaller queries or normal day-to-day operations? is there a way to ease this on for larger queries? like say, if the query has a certain number of results, use the lower value? is that overkill?

@desa
Copy link
Contributor Author

desa commented Mar 13, 2020

This is only for the number of points per series that we display in graph when building a check. The main idea behind this feature is to give the user a window of data that they can view. If the user picked a 1m group by, they would see the last 100m of data. This is definitely not a long term solution and meant as a bandaid for an existing issue. Long term we'll want to limit the number of series that are returned to only, the top N.

This was done to reduce amount of data returned to the client. This is
problematic when there are a large number of series that get returned
from a query. Long term we will want to limit the topN tables so that
this is not an issue.
@desa desa merged commit d3b0665 into master Mar 13, 2020
@desa desa deleted the chore/alerting branch March 13, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants