Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): updated styling so that telegraf configs maintain their original size when filtering configs #17168

Merged
merged 2 commits into from
Mar 10, 2020
Merged

fix(ui): updated styling so that telegraf configs maintain their original size when filtering configs #17168

merged 2 commits into from
Mar 10, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Mar 10, 2020 •
edited
Loading

Closes #16663
Closes #17166

Problem

  1. Telegraf Config buttons were slightly off-center (too far to the right) (Telegraf Page Plugin buttons UI off-center #17166)
  2. Filtering through telegraf configs were resizing the cells beyond the screen size ([UI - Load Data / Telegrafs] Filter configuration renders plugin icons unreadable #16663)

telegraf-filter-fix

Solution

  1. Removed specific css properties to ensure that the buttons are aligned correctly
  2. Updated the sizing process so that cells don't update in size as they get filtered
  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested a review from alexpaxton March 10, 2020 13:20
@asalem1 asalem1 force-pushed the fix/filter-configs branch from 18ffd12 to c36466e Compare March 10, 2020 16:12
alexpaxton
alexpaxton approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, devil's in the details!

@asalem1 asalem1 merged commit b678ace into master Mar 10, 2020
@asalem1 asalem1 deleted the fix/filter-configs branch March 10, 2020 16:43
jacobmarble pushed a commit that referenced this pull request Mar 12, 2020
@asalem1
fix(ui): updated styling so that telegraf configs maintain their orig…
475be16 
…inal size when filtering configs (#17168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asalem1 @alexpaxton