fix(ui): fixed regression bug that preventing variable maps from properly assigning values #17072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdelambre
approved these changes
Mar 3, 2020
|
@asalem1 can you include a test for this? |
|
@desa definitely. This actually has a few tests that are failing because it messed around with the way that variable maps are intended to be displayed. I'm currently working on trying to update the solution so that the display aspect of this is maintained, but that it is functionally correct. |
…erly assigning values
…ce correct functionality
asalem1
force-pushed
the
regression/variable-map
branch
from
3aceda8 to
e2b5853
Compare
drdelambre
approved these changes
Mar 4, 2020
jacobmarble
pushed a commit
that referenced
this pull request
Mar 12, 2020
…rly assigning values (#17072) fix(ui): fixed regression bug that prevented variable maps from properly assigning values and updated tests to enforce correct functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17026
Problem
Variable maps that had previously been created were not mapping variables values out properly.
Solution
Undid a change introduced in the following PR which improperly mapped keys of the maps as the value rather than the values:
78244ce#diff-75e6c7f86f1381fe2013a292310d9d0eL164