Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kv): remove URM and Authorizations by UserID Index #16852

Merged
merged 5 commits into from
Feb 13, 2020
Merged

fix(kv): remove URM and Authorizations by UserID Index #16852

merged 5 commits into from
Feb 13, 2020

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Feb 13, 2020 •
edited
Loading

Remove new indexes for Authorizations and UserResourceMappings.
I believe they are creating an inconsistent view of the world.

UPDATE: We're blocking this until we're more certain on the scope of impact the current defect has.

I will also review which tests can be retained from this revert.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@GeorgeMac GeorgeMac changed the title Gm/revert indexes fix(kv): remove URM and Authorizations by UserID Index Feb 13, 2020
@GeorgeMac GeorgeMac added blocked and removed blocked labels Feb 13, 2020
@GeorgeMac GeorgeMac requested review from goller and e-dard February 13, 2020 15:22
@GeorgeMac GeorgeMac merged commit f239a2e into master Feb 13, 2020
@GeorgeMac GeorgeMac deleted the gm/revert-indexes branch February 13, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavincabbage gavincabbage gavincabbage approved these changes

@goller goller goller approved these changes

@e-dard e-dard Awaiting requested review from e-dard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgeMac @goller @gavincabbage