-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine interface should change to take batches of points #294
Comments
I started some work on refactoring and now it yields in series rather than individual points. This introduced new methods YieldSeries and AggregateSeries. I only optimized Count and Timestamp aggregator for now, other aggegators fall back to use AggregatePoint instead. I noticed that this gives about 2x faster execution of select count(value) from some_series; query and other queries seem to have improved. Series are being collected in datastore/leveldb_shard.go and there is POINT_BATCH_SIZE constant that defines how large batch should be. This probably should be in config file Would be great if you could take a look |
Would love to take a look, can you push to a branch and submit a PR? |
Moved this story to 0.5.5, we should also get rid of the YieldPoint method |
I think this is already done. |
Performance on some queries would be better if the engine took a batch of points instead of yielding each individual point. Refactor so that it takes a YieldSeries instead of YieldPoint
The text was updated successfully, but these errors were encountered: