Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block read error should move aside bad TSM file #25838

Closed
davidby-influx opened this issue Jan 15, 2025 · 0 comments · Fixed by #25839
Closed

block read error should move aside bad TSM file #25838

davidby-influx opened this issue Jan 15, 2025 · 0 comments · Fixed by #25839
Assignees
@davidby-influx
Labels
1.x area/tsm area/2.x OSS 2.0 related issues and PRs kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

When a read of a TSM file fails in compaction,
that file should be renamed and moved aside
so it is not read again. The code to do this
has a bug in checking the error type for
errBlockRead, so bad files are not currently
being moved aside.
@davidby-influx davidby-influx self-assigned this Jan 15, 2025
@davidby-influx davidby-influx mentioned this issue Jan 15, 2025
Merged
@davidby-influx davidby-influx linked a pull request Jan 15, 2025 that will close this issue
fix: move aside TSM file on errBlockRead #25839
Merged
@davidby-influx davidby-influx mentioned this issue Jan 15, 2025
Closed
davidby-influx added a commit that referenced this issue Jan 22, 2025
@davidby-influx
fix: move aside TSM file on errBlockRead (#25839)
8009704 
The error type check for errBlockRead was incorrect,
and bad TSM files were not being moved aside when
that error was encountered. Use errors.Join,
errors.Is, and errors.As to correctly unwrap multiple
errors.

Closes #25838
davidby-influx added a commit that referenced this issue Jan 22, 2025
@davidby-influx
fix: move aside TSM file on errBlockRead (#25839)
c970b22 
The error type check for errBlockRead was incorrect,
and bad TSM files were not being moved aside when
that error was encountered. Use errors.Join,
errors.Is, and errors.As to correctly unwrap multiple
errors.

Closes #25838

(cherry picked from commit 8009704)

Closes #25840
@davidby-influx davidby-influx mentioned this issue Jan 22, 2025
Merged
davidby-influx added a commit that referenced this issue Jan 22, 2025
@davidby-influx
fix: move aside TSM file on errBlockRead (#25899)
dd7b4ce 
The error type check for errBlockRead was incorrect,
and bad TSM files were not being moved aside when
that error was encountered. Use errors.Join,
errors.Is, and errors.As to correctly unwrap multiple
errors.

Closes #25838

(cherry picked from commit 8009704)

Closes #25840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/tsm area/2.x OSS 2.0 related issues and PRs kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move aside TSM file on errBlockRead influxdata/influxdb
1 participant
@davidby-influx