Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data race between test and product code in partition compaction [Port to main-2.x branch] #25341

Closed
devanbenz opened this issue Sep 16, 2024 · 1 comment
Closed

data race between test and product code in partition compaction [Port to main-2.x branch] #25341

devanbenz opened this issue Sep 16, 2024 · 1 comment
Assignees
@devanbenz
Labels
area/tsi area/2.x OSS 2.0 related issues and PRs team/edge

Comments

@devanbenz
Copy link

Port #24040 to main-2.x branch
@devanbenz devanbenz added area/tsi area/2.x OSS 2.0 related issues and PRs team/edge labels Sep 16, 2024
@devanbenz devanbenz self-assigned this Sep 16, 2024
devanbenz added a commit that referenced this issue Sep 17, 2024
@devanbenz
fix(tsi1/partition/test): fix data races in test code (#57) (#25338)
f4af211 
* fix(tsi1/partition/test): fix data races in test code (#57)

* fix(tsi1/partition/test): fix data races in test code

This PR is like #24613 but solves it with a setter
method for MaxLogFileSize which allows unexporting that value and
MaxLogFileAge. There are actually two places locks were needed in test
code. The behavior of production code is unchanged.

(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

* feat: modify error handling to be more idiomatic

closes #24042

* fix: errors.Join() filters nil errors

closes #25341
---------

Co-authored-by: Phil Bracikowski <[email protected]>
(cherry picked from commit 5c9e45f)
@devanbenz devanbenz mentioned this issue Sep 17, 2024
Merged
2 tasks
devanbenz added a commit that referenced this issue Sep 17, 2024
@devanbenz
fix(tsi1/partition/test): fix data races in test code (#57) (#25338) (#…
b88e74e 
…25344)

* fix(tsi1/partition/test): fix data races in test code (#57)

* fix(tsi1/partition/test): fix data races in test code

This PR is like #24613 but solves it with a setter
method for MaxLogFileSize which allows unexporting that value and
MaxLogFileAge. There are actually two places locks were needed in test
code. The behavior of production code is unchanged.

(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

* feat: modify error handling to be more idiomatic

closes #24042

* fix: errors.Join() filters nil errors

closes #25341
---------

Co-authored-by: Phil Bracikowski <[email protected]>
(cherry picked from commit 5c9e45f)
devanbenz added a commit that referenced this issue Sep 17, 2024
@devanbenz
fix(tsi1/partition/test): fix data races in test code (#57) (#25338) (#…
90cce80 
…25344)

* fix(tsi1/partition/test): fix data races in test code (#57)

* fix(tsi1/partition/test): fix data races in test code

This PR is like #24613 but solves it with a setter
method for MaxLogFileSize which allows unexporting that value and
MaxLogFileAge. There are actually two places locks were needed in test
code. The behavior of production code is unchanged.

(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

* feat: modify error handling to be more idiomatic

closes #24042

* fix: errors.Join() filters nil errors

closes #25341
---------

Co-authored-by: Phil Bracikowski <[email protected]>
(cherry picked from commit 5c9e45f)
(cherry picked from commit b88e74e)

closes #25342
@devanbenz devanbenz mentioned this issue Sep 17, 2024
Merged
devanbenz added a commit that referenced this issue Sep 17, 2024
@devanbenz
fix(tsi1/partition/test): fix data races in test code (return error i…
7c652cd 
…nstead of panic when type of time != float #57)

fix(tsi1/partition/test): fix data races in test code

This PR is like #24613 but solves it with a setter method for MaxLogFileSize which allows unexporting that value and MaxLogFileAge. There are actually two places locks were needed in test code. The behavior of production code is unchanged.

(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

feat: modify error handling to be more idiomatic
closes #24042

fix: errors.Join() filters nil errors
closes #25341 ---------

Co-authored-by: Phil Bracikowski [email protected]
(cherry picked from commit 5c9e45f) (cherry picked from commit b88e74e)

closes #25342
@devanbenz
Copy link
Author

Closing

devanbenz added a commit that referenced this issue Sep 17, 2024
@devanbenz
fix(tsi1/partition/test): fix data races in test code (#57) (#25338)
0dd9db0 
* fix(tsi1/partition/test): fix data races in test code (#57)

* fix(tsi1/partition/test): fix data races in test code

This PR is like #24613 but solves it with a setter
method for MaxLogFileSize which allows unexporting that value and
MaxLogFileAge. There are actually two places locks were needed in test
code. The behavior of production code is unchanged.

(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

* feat: modify error handling to be more idiomatic

closes #24042

* fix: errors.Join() filters nil errors

closes #25341
---------

Co-authored-by: Phil Bracikowski <[email protected]>
(cherry picked from commit 5c9e45f)
(cherry picked from commit b88e74e)

closes #25342
devanbenz added a commit that referenced this issue Sep 17, 2024
@devanbenz
fix(tsi1/partition/test): fix data races in test code (#57) (#25338) … (
07df053 
#25352)

* fix(tsi1/partition/test): fix data races in test code (#57)

* fix(tsi1/partition/test): fix data races in test code

This PR is like #24613 but solves it with a setter
method for MaxLogFileSize which allows unexporting that value and
MaxLogFileAge. There are actually two places locks were needed in test
code. The behavior of production code is unchanged.

(cherry picked from commit f0235c4daf4b97769db932f7346c1d3aecf57f8f)

* feat: modify error handling to be more idiomatic

closes #24042

* fix: errors.Join() filters nil errors

closes #25341
---------

Co-authored-by: Phil Bracikowski <[email protected]>
(cherry picked from commit 5c9e45f)
(cherry picked from commit b88e74e)

closes #25342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devanbenz devanbenz

Labels
area/tsi area/2.x OSS 2.0 related issues and PRs team/edge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devanbenz