Use Size() instead of encoding

influxdata · May 30, 2014 · e9b2ce5 · e9b2ce5
1 parent 6e46865
commit e9b2ce5
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/coordinator/protobuf_request_handler.go b/src/coordinator/protobuf_request_handler.go
@@ -115,12 +115,7 @@ func (self *ProtobufRequestHandler) handleDropDatabase(request *protocol.Request
 }
 
 func (self *ProtobufRequestHandler) WriteResponse(conn net.Conn, response *protocol.Response) error {
-	data, err := response.Encode()
-	if err != nil {
-		log.Error("error encoding response: %s", err)
-		return err
-	}
-	if len(data) >= MAX_RESPONSE_SIZE {
+	if response.Size() >= MAX_RESPONSE_SIZE {
 		pointCount := len(response.Series.Points)
 		firstHalfPoints := response.Series.Points[:pointCount]
 		secondHalfPoints := response.Series.Points[pointCount:]
@@ -133,6 +128,12 @@ func (self *ProtobufRequestHandler) WriteResponse(conn net.Conn, response *proto
 		return self.WriteResponse(conn, response)
 	}
 
+	data, err := response.Encode()
+	if err != nil {
+		log.Error("error encoding response: %s", err)
+		return err
+	}
+
 	buff := bytes.NewBuffer(make([]byte, 0, len(data)+8))
 	binary.Write(buff, binary.LittleEndian, uint32(len(data)))
 	_, err = conn.Write(append(buff.Bytes(), data...))