Skip to content

Commit

Permalink
fix(variablelist): fix sort by variable type (#16935)
Browse files Browse the repository at this point in the history
  • Loading branch information
russorat authored Feb 21, 2020
1 parent fae020a commit b8130bf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
1. [16919](https://github.com/influxdata/influxdb/pull/16919): Sort dashboards on homepage alphabetically
1. [16934](https://github.com/influxdata/influxdb/pull/16934): Tokens page now sorts by status
1. [16931](https://github.com/influxdata/influxdb/pull/16931): Set the defualt value of tags in a Check
1. [16935](https://github.com/influxdata/influxdb/pull/16935): Fix sort by variable type

## v2.0.0-beta.4 [2020-02-14]

Expand Down
4 changes: 2 additions & 2 deletions ui/src/variables/components/VariableList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {Sort} from '@influxdata/clockface'
// Selectors
import {getSortedResources} from 'src/shared/utils/sort'

type SortKey = keyof Variable
type SortKey = keyof Variable | 'arguments.type'

interface Props {
variables: Variable[]
Expand Down Expand Up @@ -77,7 +77,7 @@ export default class VariableList extends PureComponent<Props, State> {
}

private get headerKeys(): SortKey[] {
return ['name', 'arguments']
return ['name', 'arguments.type']
}

private get rows(): JSX.Element[] {
Expand Down

0 comments on commit b8130bf

Please sign in to comment.