feat: hide cell move buttons behind feature flag (#19350)

influxdata · Aug 20, 2020 · 45b1f86 · 45b1f86
1 parent 0780232
commit 45b1f86
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/ui/src/notebooks/components/panel/NotebookPanel.tsx b/ui/src/notebooks/components/panel/NotebookPanel.tsx
@@ -23,6 +23,7 @@ import InsertCellButton from 'src/notebooks/components/panel/InsertCellButton'
 import PanelVisibilityToggle from 'src/notebooks/components/panel/PanelVisibilityToggle'
 import MovePanelButton from 'src/notebooks/components/panel/MovePanelButton'
 import NotebookPanelTitle from 'src/notebooks/components/panel/NotebookPanelTitle'
+import {FeatureFlag} from 'src/shared/utils/featureFlag'
 
 // Types
 import {PipeContextProps} from 'src/notebooks'
@@ -81,16 +82,18 @@ const NotebookPanelHeader: FC<HeaderProps> = ({id, controls}) => {
         justifyContent={JustifyContent.FlexEnd}
       >
         {controls}
-        <MovePanelButton
-          direction="up"
-          onClick={moveUp}
-          active={canBeMovedUp}
-        />
-        <MovePanelButton
-          direction="down"
-          onClick={moveDown}
-          active={canBeMovedDown}
-        />
+        <FeatureFlag name="notebook-move-cells">
+          <MovePanelButton
+            direction="up"
+            onClick={moveUp}
+            active={canBeMovedUp}
+          />
+          <MovePanelButton
+            direction="down"
+            onClick={moveDown}
+            active={canBeMovedDown}
+          />
+        </FeatureFlag>
         <PanelVisibilityToggle id={id} />
         <RemovePanelButton onRemove={remove} />
       </FlexBox>

diff --git a/ui/src/shared/selectors/flags.ts b/ui/src/shared/selectors/flags.ts
@@ -13,6 +13,7 @@ export const OSS_FLAGS = {
   notebooks: false,
   telegrafEditor: false,
   streamEvents: false,
+  'notebook-move-cells': false,
   'notebook-panel--spotify': false,
   'notebook-panel--test-flux': false,
   disableDefaultTableSort: false,
@@ -36,6 +37,7 @@ export const CLOUD_FLAGS = {
   notebooks: false,
   telegrafEditor: false,
   streamEvents: false,
+  'notebook-move-cells': false,
   'notebook-panel--spotify': false,
   'notebook-panel--test-flux': false,
   disableDefaultTableSort: false,