Skip to content

Commit

Permalink
chore(pkger): fixup tracing span creation
Browse files Browse the repository at this point in the history
fallback to using the packge.method(type).additional format
  • Loading branch information
jsteenb2 committed Jun 4, 2020
1 parent 40f2c91 commit 09843e1
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions pkger/service_tracing.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,27 @@ func MWTracing() SVCMiddleware {
var _ SVC = (*traceMW)(nil)

func (s *traceMW) InitStack(ctx context.Context, userID influxdb.ID, newStack Stack) (Stack, error) {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "InitStack")
span, ctx := tracing.StartSpanFromContext(ctx)
defer span.Finish()
return s.next.InitStack(ctx, userID, newStack)
}

func (s *traceMW) DeleteStack(ctx context.Context, identifiers struct{ OrgID, UserID, StackID influxdb.ID }) error {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "DeleteStack")
span, ctx := tracing.StartSpanFromContext(ctx)
defer span.Finish()
return s.next.DeleteStack(ctx, identifiers)
}

func (s *traceMW) ExportStack(ctx context.Context, orgID, stackID influxdb.ID) (*Pkg, error) {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "ExportStack")
span, ctx := tracing.StartSpanFromContext(ctx)
span.LogFields(log.String("org_id", orgID.String()))
span.LogFields(log.String("stack_id", stackID.String()))
defer span.Finish()
return s.next.ExportStack(ctx, orgID, stackID)
}

func (s *traceMW) ListStacks(ctx context.Context, orgID influxdb.ID, f ListFilter) ([]Stack, error) {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "ListStacks")
span, ctx := tracing.StartSpanFromContext(ctx)
defer span.Finish()

stacks, err := s.next.ListStacks(ctx, orgID, f)
Expand All @@ -54,20 +54,20 @@ func (s *traceMW) ListStacks(ctx context.Context, orgID influxdb.ID, f ListFilte
}

func (s *traceMW) CreatePkg(ctx context.Context, setters ...CreatePkgSetFn) (pkg *Pkg, err error) {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "CreatePkg")
span, ctx := tracing.StartSpanFromContext(ctx)
defer span.Finish()
return s.next.CreatePkg(ctx, setters...)
}

func (s *traceMW) DryRun(ctx context.Context, orgID, userID influxdb.ID, pkg *Pkg, opts ...ApplyOptFn) (PkgImpactSummary, error) {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "DryRun")
span, ctx := tracing.StartSpanFromContext(ctx)
span.LogKV("orgID", orgID.String(), "userID", userID.String())
defer span.Finish()
return s.next.DryRun(ctx, orgID, userID, pkg, opts...)
}

func (s *traceMW) Apply(ctx context.Context, orgID, userID influxdb.ID, pkg *Pkg, opts ...ApplyOptFn) (PkgImpactSummary, error) {
span, ctx := tracing.StartSpanFromContextWithOperationName(ctx, "Apply")
span, ctx := tracing.StartSpanFromContext(ctx)
span.LogKV("orgID", orgID.String(), "userID", userID.String())
defer span.Finish()
return s.next.Apply(ctx, orgID, userID, pkg, opts...)
Expand Down

0 comments on commit 09843e1

Please sign in to comment.