Skip to content

Commit

Permalink
fix(ui): fixed yield bug that was caused by race condition (#17208)
Browse files Browse the repository at this point in the history
  • Loading branch information
asalem1 authored Mar 11, 2020
1 parent 8e4fdce commit 0980773
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
1. [17049](https://github.com/influxdata/influxdb/pull/17049): Fixed bug that was preventing the interval status on the dashboard header from refreshing on selections
1. [17161](https://github.com/influxdata/influxdb/pull/17161): Update table custom decimal feature for tables to update table onFocus
1. [17168](https://github.com/influxdata/influxdb/pull/17168): Fixed UI bug that was setting Telegraf config buttons off-center and was resizing config selections when filtering through the data
1. [17208](https://github.com/influxdata/influxdb/pull/17208): Fixed UI bug that was setting causing dashboard cells to error when the a v.bucket was being used and was being configured for the first time

## v2.0.0-beta.5 [2020-02-27]

Expand Down
7 changes: 5 additions & 2 deletions ui/src/timeMachine/actions/queries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,11 @@ export const executeQueries = (dashboardID?: string) => async (
dispatch(setQueryResults(RemoteDataState.Loading, [], null))

await dispatch(refreshTimeMachineVariableValues(dashboardID))

const variableAssignments = getVariableAssignments(state)
// keeping getState() here ensures that the state we are working with
// is the most current one. By having this set to state, we were creating a race
// condition that was causing the following bug:
// https://github.com/influxdata/idpe/issues/6240
const variableAssignments = getVariableAssignments(getState())
const orgID = getOrg(state).id

const startTime = Date.now()
Expand Down

0 comments on commit 0980773

Please sign in to comment.