Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add FluxRecord.row with response data stored in array #502

Merged
merged 3 commits into from
Sep 21, 2022
Merged

feat: add FluxRecord.row with response data stored in array #502

merged 3 commits into from
Sep 21, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 14, 2022 •
edited
Loading

Closes #500

Proposed Changes

This PR add possibility to access response data by FluxRecord.row array. It is useful for an edge case where the column names are duplicated and FluxRecord.values dictionary cannot be used.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar mentioned this pull request Sep 14, 2022
Closed
@bednar bednar marked this pull request as ready for review September 14, 2022 09:20
@bednar bednar requested a review from powersj September 14, 2022 09:20
powersj
powersj approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bednar bednar merged commit da73522 into master Sep 21, 2022
@bednar bednar deleted the record-row-array branch September 21, 2022 18:27
@bednar bednar added this to the 1.33.0 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.

FluxTable / FluxRecord can't handle tables with duplicate column labels
2 participants
@bednar @powersj