-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: creating Tasks
with import
statements
#491
Conversation
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 39 39
Lines 3355 3355
=======================================
Hits 3037 3037
Misses 318 318
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I'll leave this up to see if the original reporter also confirms the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fix is fine for most use cases. See comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #490
Proposed Changes
Fixed creating
Task
with import statement:Checklist
pytest tests
completes successfully