Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: querying data if the debug is enabled #483

Merged
merged 3 commits into from
Aug 5, 2022
Merged

fix: querying data if the debug is enabled #483

merged 3 commits into from
Aug 5, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 4, 2022 •
edited
Loading

Closes #480

Proposed Changes

The HTTP response can be exhausted by logger, so we have to use data that has already been read.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar mentioned this pull request Aug 4, 2022
Closed
@bednar bednar requested review from rhajek and powersj August 5, 2022 04:13
@bednar bednar marked this pull request as ready for review August 5, 2022 04:13
powersj
powersj approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for tracking this down!

@powersj powersj merged commit 1ca6690 into master Aug 5, 2022
@powersj powersj deleted the exhausted_response branch August 5, 2022 16:49
@bednar bednar added this to the 1.32.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@rhajek rhajek Awaiting requested review from rhajek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.

Query "buckets()" returns empty list when debug is enabled
2 participants
@bednar @powersj