-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add an example: How to use RxPY to prepare batches by maximum bytes count. #397
Conversation
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 39 39
Lines 3355 3355
=======================================
Hits 3037 3037
Misses 318 318 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed on not modifying the underlying library for this. The example looks good!
@rhajek thoughts on this one? |
The example as a workaround is ok. |
Thanks @bednar can you update the README change for this PR and we can land this? |
@powersj the sources are rebased and updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Closes #392
Proposed Changes
Added an example:
How to use RxPY to prepare batches by maximum bytes count.
Checklist
pytest tests
completes successfully