Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add an example: How to use RxPY to prepare batches by maximum bytes count. #397

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 24, 2022

Closes #392

Proposed Changes

Added an example: How to use RxPY to prepare batches by maximum bytes count.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review January 24, 2022 12:53
@bednar bednar requested a review from rhajek January 24, 2022 12:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #397 (ec9a781) into master (7a24f63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          39       39           
  Lines        3355     3355           
=======================================
  Hits         3037     3037           
  Misses        318      318           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed on not modifying the underlying library for this. The example looks good!

@powersj
Copy link
Contributor

powersj commented Aug 5, 2022

@rhajek thoughts on this one?

@rhajek
Copy link
Contributor

rhajek commented Aug 8, 2022

The example as a workaround is ok.

@powersj
Copy link
Contributor

powersj commented Aug 8, 2022

The example as a workaround is ok.

Thanks

@bednar can you update the README change for this PR and we can land this?

@bednar
Copy link
Contributor Author

bednar commented Aug 9, 2022

@powersj the sources are rebased and updated to RxPY v4.0.4

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@powersj powersj merged commit 12ab822 into master Aug 9, 2022
@powersj powersj deleted the example_bytes branch August 9, 2022 13:25
@bednar bednar added this to the 1.32.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split requests for max-body-size
4 participants