Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks_api): fixed get_run to use proper function #193

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

russorat
Copy link
Contributor

Closes #

Proposed Changes

Briefly describe your proposed changes:
I was trying to get a single run for a task and was getting the following error:
Got an unexpected keyword argument 'run_id' to method get_tasks_id_runs

From what I could tell, the lib was using the wrong function to get a specific run by id.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@russorat russorat requested a review from rhajek February 12, 2021 00:16
@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #193 (bcf43a7) into master (38bf155) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          26       26           
  Lines        1967     1967           
=======================================
  Hits         1767     1767           
  Misses        200      200           
Impacted Files Coverage Δ
influxdb_client/client/tasks_api.py 81.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bf155...a41a2ec. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@bednar bednar merged commit d396581 into master Feb 12, 2021
@bednar bednar deleted the fix-tasks-get-run branch February 12, 2021 08:41
@bednar bednar added this to the 1.15.0 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants